Rsclub2_2/kst4contest
1
0
Fork 0
mirror of https://github.com/praktimarc/kst4contest.git synced 2026-09-11 11:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fail cleanly when the registry path has no directory

Browse Source 
SpotBugs flagged a null passed to Files.createTempFile: the null check guarded
only createDirectories, while the temporary file creation would still have
dereferenced it. The path is resolved absolute so this is practically
unreachable, but bailing out with a log line is cheaper than the latent NPE.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Hpa6bjie5qkeNG62y6FmXm
This commit is contained in:
Claude
2026-09-07 22:22:45 +02:00
committed by Rsclub2_2
parent e5e6036188
commit 174c77a037
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/kst4contest/controller/OperatorProfileStore.java
+10 -4
View File
@@ -348,11 +348,17 @@ public class OperatorProfileStore {
Path targetPath = Path.of(registryFilePath).toAbsolutePath(); Path targetPath = Path.of(registryFilePath).toAbsolutePath();
Path parentDirectory = targetPath.getParent(); Path parentDirectory = targetPath.getParent();
try { if (parentDirectory == null) {
if (parentDirectory != null) { LOGGER.log(Level.SEVERE,
Files.createDirectories(parentDirectory); "The operator profile registry path has no directory: {0}", registryFilePath);
} return false;
}
try {
Files.createDirectories(parentDirectory);
// The temporary file has to live next to the target so the final move can be
// atomic; both must be on the same file system.
Path temporaryPath = Files.createTempFile( Path temporaryPath = Files.createTempFile(
parentDirectory, PROFILES_REGISTRY_FILE, ".tmp"); parentDirectory, PROFILES_REGISTRY_FILE, ".tmp");