Switching the operator profile tears the current runtime down completely and builds + * a fresh one in the same process. Rebinding the existing windows is not an option: the + * user interface is built from the chat controller outwards, with several hundred + * references to the active preferences, and many controls are instance fields created + * once. A new {@link Kst4ContestApplication} instance gets fresh controls, which is safe + * here because the class keeps no mutable static state.
+ */ +public final class ApplicationRuntimeLauncher { + + private static final Logger LOGGER = Logger.getLogger(ApplicationRuntimeLauncher.class.getName()); + + private static Kst4ContestApplication currentRuntime; + + private ApplicationRuntimeLauncher() { + // Utility class. + } + + /** + * Registers the runtime that is currently live. + * + * @param runtime the running application instance + */ + public static void setCurrent(final Kst4ContestApplication runtime) { + currentRuntime = runtime; + } + + /** + * Returns the runtime that is currently live. + * + * @return the running application instance, or null before the first startup + */ + public static Kst4ContestApplication getCurrent() { + return currentRuntime; + } + + /** + * Shuts the application down. + * + *JavaFX only calls {@code stop()} on the instance it launched itself, so an exit + * after a profile switch has to release the resources explicitly.
+ */ + public static void exitApplication() { + + if (currentRuntime != null) { + currentRuntime.shutdownRuntime(); + } + + Platform.exit(); + System.exit(0); + } + + /** + * Replaces the running runtime with one bound to another operator profile. + * + * @param targetProfile profile to activate + * @return true if the new runtime was built + */ + public static boolean switchProfile(final OperatorProfile targetProfile) { + + if (targetProfile == null) { + return false; + } + + new OperatorProfileStore().recordLastUsed(targetProfile.getProfileId()); + + if (currentRuntime != null) { + currentRuntime.shutdownRuntime(); + } + + ActiveOperatorProfile.set(OperatorProfilePaths.resolve(targetProfile)); + + Kst4ContestApplication nextRuntime = new Kst4ContestApplication(); + + try { + nextRuntime.start(new Stage()); + } catch (Exception e) { + // The previous runtime is already gone, so there is nothing left to return to. + LOGGER.log(Level.SEVERE, "Could not start the selected operator profile", e); + Kst4ContestApplication.alertWindowEvent( + "The operator profile could not be started: " + e.getMessage() + + "\n\nKST4Contest has to be closed."); + Platform.exit(); + System.exit(1); + return false; + } + + setCurrent(nextRuntime); + return true; + } +} diff --git a/src/main/java/kst4contest/view/Kst4ContestApplication.java b/src/main/java/kst4contest/view/Kst4ContestApplication.java index fcdcaf00..c9a67f04 100644 --- a/src/main/java/kst4contest/view/Kst4ContestApplication.java +++ b/src/main/java/kst4contest/view/Kst4ContestApplication.java @@ -15,6 +15,7 @@ import java.util.logging.SimpleFormatter; import java.util.function.Consumer; import java.util.function.Predicate; +import javafx.animation.Animation; import javafx.animation.KeyFrame; import javafx.animation.Timeline; import javafx.collections.FXCollections; @@ -72,6 +73,8 @@ import kst4contest.utils.ApplicationFileUtils; import kst4contest.view.map.StationMapBridge; import kst4contest.controller.ActiveOperatorProfile; import kst4contest.controller.OperatorProfileStore; +import kst4contest.controller.OperatorProfilePaths; +import kst4contest.model.OperatorProfile; import kst4contest.model.OperatorProfileSelection; import kst4contest.view.map.StationMapView; import kst4contest.view.map.OfflineDemImportService; @@ -5503,6 +5506,9 @@ public class Kst4ContestApplication extends Application implements StatusUpdateL }); + MenuItem menuItemFileSwitchProfile = new MenuItem("Switch operator profile..."); + menuItemFileSwitchProfile.setOnAction(event -> showOperatorProfileSwitchDialog()); + MenuItem m10 = new MenuItem("Exit + disconnect"); m10.setOnAction(new EventHandlerOffers to create a second profile when only one exists, because the menu entry + * is the discoverable place to find the feature at all.
+ */ + private void showOperatorProfileSwitchDialog() { + + OperatorProfileStore profileStore = new OperatorProfileStore(); + ListSeparated from {@link #stop()} so the same teardown can be reused when the + * operator switches to another profile and a fresh runtime is built afterwards. + * The method is idempotent and tolerates a runtime that never connected, because a + * switch may happen before the first login.
+ */ + public void shutdownRuntime() { + + if (runtimeShutdownDone) { + return; } - timer_buildWindowTitle.purge(); - timer_buildWindowTitle.cancel(); + + runtimeShutdownDone = true; + + System.out.println("[Main.java, Info:] Stage is closing, killing all resources"); + + if (layoutAutosave != null) { + // Flush before cancelling, otherwise a pending debounced write would either + // be lost or land after a profile switch. + layoutAutosave.flushPending(); + layoutAutosave.cancelPending(); + } + + cancelViewTimer(timer_buildWindowTitle); + timer_buildWindowTitle = null; // timer_chatMemberTableSortTimer.purge(); // timer_chatMemberTableSortTimer.cancel(); - timer_updatePrivatemessageTable.purge(); - timer_updatePrivatemessageTable.cancel(); + cancelViewTimer(timer_updatePrivatemessageTable); + timer_updatePrivatemessageTable = null; + + stopAnimation(userListRefreshCoalescer); + userListRefreshCoalescer = null; + stopAnimation(skedWarnBlinkTimeline); + skedWarnBlinkTimeline = null; + stopAnimation(bandUpgradeBlinkTimeline); + bandUpgradeBlinkTimeline = null; + + if (stationMapBridge != null) { + stationMapBridge.uninstall(); + stationMapBridge = null; + } + + if (stationMapView != null) { + stationMapView.dispose(); + stationMapView = null; + } + + closeOwnedStages(); try { - chatcontroller.disconnect("CLOSEALL"); + if (chatcontroller != null) { + chatcontroller.disconnect(ApplicationConstants.DISCSTRING_DISCONNECT_AND_CLOSE); + } } catch (Exception e) { System.out.println("[Main.java, Warning:] Exception during disconnect: " + e.getMessage()); } + } -// Platform.exit(); - System.exit(0); + /** + * Cancels a timer created during user interface construction. + * + * @param timerToCancel timer to cancel, may be null when startup did not get that far + */ + private static void cancelViewTimer(Timer timerToCancel) { + + if (timerToCancel == null) { + return; + } + + timerToCancel.purge(); + timerToCancel.cancel(); + } + + /** + * Stops a JavaFX animation if it exists. + * + * @param animationToStop animation to stop, may be null + */ + private static void stopAnimation(Animation animationToStop) { + + if (animationToStop != null) { + animationToStop.stop(); + } + } + + /** + * Closes every window this runtime opened, so no stale window survives a profile + * switch. The map window is closed by its own dispose method. + */ + private void closeOwnedStages() { + + for (Stage ownedStage : new Stage[] { + settingsStage, clusterAndQSOMonStage, stage_updateStage, ownPrimaryStage }) { + + if (ownedStage != null) { + try { + ownedStage.close(); + } catch (Exception e) { + System.out.println("[Main.java, Warning:] Could not close a window: " + e.getMessage()); + } + } + } + + settingsStage = null; + clusterAndQSOMonStage = null; + stage_updateStage = null; + ownPrimaryStage = null; } private void requestLayoutSave() { @@ -6723,6 +6903,20 @@ public class Kst4ContestApplication extends Application implements StatusUpdateL return; } + ownPrimaryStage = primaryStage; + + /* + * A profile switch closes every window of the old runtime before the new one + * exists. With the JavaFX default that would end the process, so the application + * takes over the exit decision and closing the main window is handled explicitly. + */ + Platform.setImplicitExit(false); + primaryStage.setOnCloseRequest(closeRequest -> { + closeRequest.consume(); + ApplicationRuntimeLauncher.exitApplication(); + }); + ApplicationRuntimeLauncher.setCurrent(this); + GuiUtils.applyApplicationIcon(primaryStage); VBox pnl_inputAndSendButtons = new VBox(); //gets the sendtext field, send button and the timeline @@ -12261,10 +12455,12 @@ public class Kst4ContestApplication extends Application implements StatusUpdateL if (res.get().equals(ButtonType.CANCEL)) { // event.consume(); } else { - System.out.println("closewindowevent: Platform.exit"); + System.out.println("closewindowevent: exiting the application"); - - Platform.exit(); + // Routed through the launcher so the runtime that is actually live + // releases its resources. After a profile switch that is no longer the + // instance JavaFX would call stop() on. + ApplicationRuntimeLauncher.exitApplication(); } } // }