mirror of
https://github.com/praktimarc/kst4contest.git
synced 2026-11-19 01:52:29 +01:00
Keep a running switch's wizard request when a second rerun is refused
rerunSetupWizard set the one-shot request before it tried to obtain the switch, and cleared it when the switch was refused. A second confirmed call during the first one's window teardown therefore removed the first call's request: the session ended and the profile restarted without the wizard. The request is now set only by the call that owns the switch. Written-by: Claude Fable 5.2
This commit is contained in:
2 files changed
+85
-38
No files matched your search
+28
-2
@@ -43,15 +43,41 @@ class ApplicationRuntimeLauncherSetupWizardTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
void rerunSetupWizardWhileSwitchInProgressReturnsFalseAndClearsRequest() {
|
||||
void aRefusedRerunLeavesTheRequestOfTheRunningSwitchAlone() {
|
||||
OperatorProfileSelection previous = ActiveOperatorProfile.get();
|
||||
OperatorProfile profile = new OperatorProfile("wizard-guard-test", "Wizard Guard Test", false, false);
|
||||
ActiveOperatorProfile.set(new OperatorProfileSelection(profile, "preferences.xml", "worked.db", false));
|
||||
|
||||
// A first rerun is under way: it holds the guard and its request waits for startRuntime.
|
||||
assertTrue(ApplicationRuntimeLauncher.beginSwitch());
|
||||
ApplicationRuntimeLauncher.requestSetupWizard();
|
||||
try {
|
||||
// A second one arrives while the first tears its windows down, and is refused.
|
||||
assertFalse(ApplicationRuntimeLauncher.rerunSetupWizard());
|
||||
|
||||
assertTrue(ApplicationRuntimeLauncher.consumeSetupWizardRequest(),
|
||||
"the refused rerun took the running switch's request with it: that switch "
|
||||
+ "would end the session and then start without the wizard");
|
||||
} finally {
|
||||
ApplicationRuntimeLauncher.endSwitch();
|
||||
ApplicationRuntimeLauncher.consumeSetupWizardRequest();
|
||||
ActiveOperatorProfile.set(previous);
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void aRefusedRerunLeavesNoRequestOfItsOwn() {
|
||||
OperatorProfileSelection previous = ActiveOperatorProfile.get();
|
||||
OperatorProfile profile = new OperatorProfile("wizard-guard-test", "Wizard Guard Test", false, false);
|
||||
ActiveOperatorProfile.set(new OperatorProfileSelection(profile, "preferences.xml", "worked.db", false));
|
||||
|
||||
// A plain profile switch is under way; nobody asked for the wizard.
|
||||
assertTrue(ApplicationRuntimeLauncher.beginSwitch());
|
||||
try {
|
||||
assertFalse(ApplicationRuntimeLauncher.rerunSetupWizard());
|
||||
|
||||
assertFalse(ApplicationRuntimeLauncher.consumeSetupWizardRequest(),
|
||||
"a refused rerun must not leave a wizard request behind");
|
||||
"a refused rerun must not hand its wizard to the switch that refused it");
|
||||
} finally {
|
||||
ApplicationRuntimeLauncher.endSwitch();
|
||||
ApplicationRuntimeLauncher.consumeSetupWizardRequest();
|
||||
|
||||
Reference in new issue
Block a user